BUG: Use HashableT rather than Hashable to improve compat #154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use HashableT so that any hashable object can be use in a list or iterator
Dr-Irv
approved these changes
Jul 20, 2022
twoertwein
reviewed
Jul 20, 2022
| @@ -611,7 +612,7 @@ class DataFrame(NDFrame, OpsMixin): | |||
| def set_index( | |||
| self, | |||
| keys: Union[ | |||
| Label, Series, Index, np.ndarray, Iterator[Hashable], List[Hashable] | |||
| Label, Series, Index, np.ndarray, Iterator[HashableT], List[HashableT] | |||
There was a problem hiding this comment.
I think the Iterator wouldn't have needed the TypeVar:
from typing import Iterator, Hashable
def test(x: Iterator[Hashable]):
...
def iter() -> Iterator[str]:
...
test(iter())
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use HashableT so that any hashable object can be use in a list or iterator
List[str]#153(Replace xxxx with the Github issue number)assert_type()to assert the type of any return value